Commonmark: gfmExtensions needs to precede the defaultSyntaxSpec (#1000,#1001) #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This import is not needed since we require GHC >= 8.8.
#1001) - Move `gfmExtensions` before `defaultSyntaxSpec`. - Require commonmark-extensions-0.2.2 so `footnoteSpec` is subsumed under `gfmExtensions`. (Note: this version bump does not exclude any GHC versions.) - Generalize `renderMarkdown` and `renderMarkdownRel` to `renderMarkdown'`. We use a constraint synonym to gather all the constraints on type `a`, using `LANGUAGE ConstraintKinds`. - Haddockumentation for all functions. - Explicit export list. Hopefully this will fix #1000 and #1001, but `renderMarkdown` has no tests, so I cannot see the effect of my change locally.
1 task
gbaz
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commonmark:
gfmExtensionsneeds to precede thedefaultSyntaxSpec.Move
gfmExtensionsbeforedefaultSyntaxSpec.Require commonmark-extensions-0.2.2 so
footnoteSpecis subsumed undergfmExtensions.(Note: this version bump does not exclude any GHC versions.)
Generalize
renderMarkdownandrenderMarkdownReltorenderMarkdown'. We use a constraint synonym to gather all the constraints on typea, usingLANGUAGE ConstraintKinds.Haddockumentation for all functions.
Explicit export list.
Hopefully this will fix #1000 and fix #1001, but
renderMarkdownhas no tests, so I cannot see the effect of my change locally.