Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackage should reject tarballs that have modification times in the future #159

Closed
peti opened this issue Nov 26, 2013 · 2 comments
Closed

Comments

@peti
Copy link
Contributor

peti commented Nov 26, 2013

http://hackage.haskell.org/package/indexed-free-0.3.0/indexed-free-0.3.0.tar.gz claims that its contents was created in the year 2022:

[simons@peti:~]$ tar tfv /tmp/indexed-free-0.3.0.tar.gz 
drwxr-xr-x 0/0               0 2022-10-03 07:32 indexed-free-0.3.0/
-rw-r--r-- 0/0              48 2022-10-02 17:39 indexed-free-0.3.0/Setup.hs
-rw-r--r-- 0/0            1562 2022-10-02 06:31 indexed-free-0.3.0/LICENSE
-rw-r--r-- 0/0             836 2022-10-03 04:47 indexed-free-0.3.0/indexed-free.cabal
drwxr-xr-x 0/0               0 2022-09-29 20:10 indexed-free-0.3.0/Control/
drwxr-xr-x 0/0               0 2022-09-29 22:57 indexed-free-0.3.0/Control/MonadPlus/
drwxr-xr-x 0/0               0 2022-10-01 22:11 indexed-free-0.3.0/Control/MonadPlus/Indexed/
-rw-r--r-- 0/0            1569 2022-10-01 19:25 indexed-free-0.3.0/Control/MonadPlus/Indexed/Free.hs
drwxr-xr-x 0/0               0 2022-09-29 11:49 indexed-free-0.3.0/Control/Monad/
drwxr-xr-x 0/0               0 2022-09-30 10:04 indexed-free-0.3.0/Control/Monad/Indexed/
-rw-r--r-- 0/0            1935 2022-09-30 07:16 indexed-free-0.3.0/Control/Monad/Indexed/Free.hs
drwxr-xr-x 0/0               0 2022-10-01 11:05 indexed-free-0.3.0/Control/Monad/Indexed/Trans/
-rw-r--r-- 0/0            2279 2022-10-01 08:17 indexed-free-0.3.0/Control/Monad/Indexed/Trans/Free.hs
drwxr-xr-x 0/0               0 2022-09-30 21:10 indexed-free-0.3.0/Control/Monad/Indexed/Free/
-rw-r--r-- 0/0             366 2022-09-30 18:24 indexed-free-0.3.0/Control/Monad/Indexed/Free/Class.hs

This causes build errors with Cabal, because the build tries to re-configure itself after every step, apparently believing that index-free.cabal has changed. See NixOS/nixpkgs#1280 for a complete build log.

It woud be great if Hackage (and/or cabal dist) would contain code that attempts to prevent this kind of thing from happening.

@ndmitchell
Copy link

Note that it seems cabal-install version 1.18.0.2 using version 1.18.1.2 of the Cabal library on Windows is at fault for generating these bad packages in the first place.

@dcoutts
Copy link
Contributor

dcoutts commented Dec 18, 2013

@ndmitchell yes, and it's fixed in the dev version haskell/cabal@6ce9ca2

I have a fix for this, just testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants