This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Update implicit-hie #931
Closed
Update implicit-hie #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
reviewed
Dec 1, 2020
| @@ -17,5 +17,5 @@ allow-newer: | |||
|
|
|||
| -- To ensure the build get the version with the fix for | |||
| -- https://github.com/Avi-D-coder/implicit-hie/issues/17 | |||
| constraints: implicit-hie >= 0.1.2.3 | |||
| constraints: implicit-hie >= 0.1.2.5 | |||
| constraints: implicit-hie-cradle >= 0.3.0.0 | |||
There was a problem hiding this comment.
If we had a lower bound in impicit-hie-cradle over implicit-hie, with a hackage revision for example, we could get ride of those constraints (here and in hls too)
There was a problem hiding this comment.
@Avi-D-coder what do you think about make the hackage revision? we can wait to the next release though
There was a problem hiding this comment.
I'll take a look tomorrow
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.