Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Pull in local bindings #845

Merged
merged 4 commits into from
Oct 6, 2020
Merged

Pull in local bindings #845

merged 4 commits into from
Oct 6, 2020

Conversation

isovector
Copy link
Contributor

@isovector
Copy link
Contributor Author

Sorry for the delay on this; got tangled up on tactics. PTAL.

Copy link
Collaborator

@wz1000 wz1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This should be good to merge after a rebase to disable the flaky windows tests and applying the hlint suggestions.

@isovector
Copy link
Contributor Author

isovector commented Oct 6, 2020

Merged, but I'm not sure how to run hlint. Is there a git hook or something?

@wz1000
Copy link
Collaborator

wz1000 commented Oct 6, 2020

You can run ./fmt.sh, but the only failing hlint (as see from CI) is for LambdaCase, which is already a default extension in the cabal file, so you don't need to add it as a pragma.

@isovector
Copy link
Contributor Author

Done, thanks for the guidance here @wz1000!

@isovector
Copy link
Contributor Author

CI is green!

@wz1000 wz1000 merged commit a021701 into haskell:master Oct 6, 2020
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Pull in local bindings

* Use the same traversal

* Cleanup LambdaCase
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Pull in local bindings

* Use the same traversal

* Cleanup LambdaCase
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Pull in local bindings

* Use the same traversal

* Cleanup LambdaCase
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants