-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on Travis #24
Conversation
An addendum to the second point: I opted to keep the containerized Travis builds (which are faster) by simply not running the test suite on GHC 7.2.1, which I think is an acceptable sacrifice. |
@RyanGlScott hrm... this is a bit awkward... I was about to convert |
Ah! Well if there's a cleaner way to do this, I'd vastly prefer it over this approach.
What issue is that? |
(and more discussion can be found at haskell/cabal#3232) That being said, maybe we should just merge this one, and hope that new-build will become capable of cyclic deps before old-build is killed off for good |
That sounds reasonable to me. Other than the whole cyclic dependency hullabaloo, do you have any objections to bumping the |
nope, no objection; with older cabals there were issues requiring us to test with matching cabal versions, but with modern cabal versions this shouldn't be a problem anymore to use the latest cabal release. |
Currently, the test suite isn't run on Travis builds. This PR aims to fix that. I had to make some modifications to make this happen:
HUnit
(which we depend on for the test suite) depends ondeepseq
, so trying to naïvely runcabal install --only-dependencies --enable-tests
will result in a dependency cycle. To get around this, I have to manually specify the dependencies in.travis.yml
à labinary
.Also unfortunately, there's a Safe Haskell bug in GHC 7.2.1 that prevents it from installing(This isn't true anymore, see Run tests on Travis #24 (comment))transformers
without runningsudo ghc-pkg trust base
. But in order to usesudo
, I have to disable the containerized Travis builds.HUnit
to< 1.6
to accommodate theHUnit-1.5
release on Hackage. Also, the test suite failed to build without an explicitghc-prim
dependency.