-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testuite: doctest: move to ghcup-recommended ghc #8710
Conversation
Also sadly, this doesn't address #8147 because it's still quite tricky to run doctest locally because of the |
ghcup install ghc 8.10.7 | ||
ghcup set ghc 8.10.7 | ||
ghcup install ghc recommended | ||
ghcup set ghc recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is optimistic, but let's try it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
4a082ed
to
ce2c92f
Compare
@ulysses4ever: shall we backport immediately or wait |
@Mikolaj I doubt it will blow anything but as for backporting, I don't feel strongly either way because it's not a user-visible change. |
If this, potentially, improves CI and/or its stability, it's worth porting, because the 3.10 branch is going to stay there for a while. |
@mergify backport 3.10 |
✅ Backports have been created
|
@ulysses4ever: thank you! CI got cancelled there, so I'm rerunning and keeping watch. |
testuite: doctest: move to ghcup-recommended ghc (backport #8710)
Another stub at #8504: choosing to upgrade existing doctest rather than anything else mentioned in the ticket. It looks like, our issue with upgrading GHC 8.10 -> 9.2 was due to the default
-XGHC2021
adopted in 9.2, and nomeata suggested an easy fix (thanks!) to explicitly request-XHaskell2010
.I'm sad to declare defeat at trying to switch to the recommended way of using
doctest
these days (namely, viacabal repl
) due to a failure described in #8504 (comment) It's not only sad because we're using a not (officially) supported way of communication withdoctest
, but also because we have to employcabal-env
, which has an unclear maintenance status.I also took a liberty to use
ghcup set ghc recommended
(which is currently 9.2.5) instead of a specific version or version matrix for a couple of reasons:recommended
instead of a specific version will make sure that we're moving forward even if slowly instead of being stuck on one version until someone remembers to upgrade.Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!