Backport to 3.2 20201025 #7134

phadej · 2020-10-25T14:14:48Z

Backports

Many toolchain tools written for POSIX systems rely on the exec system call. Unfortunately, it is not possible to implement `exec` in a POSIX-compliant manner on Windows. In particular, the semantics of the `exec` implementation provided by the widely-used `msvcrt` C runtime will cause process's waiting on the `exec`'ing process to incorrectly conclude that the process has successfully terminated when in fact it is still running in another process. For this reason, the `process` library exposes the `use_process_jobs` flag to use a more strict (although still not POSIX-compliant) mechanism for tracking process completion. This is explained in this comment [2]. Unfortunately, job support in the `process` library is currently quite broken and was only recently fixed [1]. Consequently, we only enable job object support for process releases >= 1.6.8. [1] haskell/process#168 [2] https://github.com/haskell/process/blob/master/System/Process.hs#L399

This looks like an accident from a6e427a It causes cases like this to fail: $ cat foo.c int foo() { return 42; } $ cat Lib.hs module Lib where foreign import ccall "foo" foo :: Int bar = foo $ cat cabal-csrc-repl.cabal cabal-version: 2.4 name: cabal-csrc-repl version: 0.1.0.0 library exposed-modules: Lib build-depends: base ^>=4.14.0.0 C-sources: foo.c default-language: Haskell2010 $ cabal v2-repl Resolving dependencies... Build profile: -w ghc-8.10.1 -O1 In order, the following will be built (use -v for more details): - cabal-csrc-repl-0.1.0.0 (lib) (first run) Configuring library for cabal-csrc-repl-0.1.0.0.. Preprocessing library for cabal-csrc-repl-0.1.0.0.. GHCi, version 8.10.1: https://www.haskell.org/ghc/ :? for help [1 of 1] Compiling Lib ( Lib.hs, interpreted ) Ok, one module loaded. *Lib> foo ghc: ^^ Could not load '_foo', dependency unresolved. See top entry above.

Google uses `armv7-none-linux-androideabi`, analogous to `armv7-unknown-linux-gnueabi` for e.g. a 32-bit regular linux. The existing alias it not a mistake, it is the right one for 64 bit. Google for that use `aarch64-linux-android`, analogous to `aarch64-unknown-linux-android` for a 64-bi regular linux. See https://developer.android.com/ndk/guides/standalone_toolchain for evidence/details.

Fixes haskell#6421 To summarize, Cabal passes all C and C++ flags through GHC to the underlying C or C++ compiler using -optc. This works for GHC < 8.10, but now GHC expects C++ flags to come through -optcxx. This means that anything through -optc is ignored, so we cannot pass any flags to the C++ compiler. This change simply detects the GHC version and uses the correct arguments. This PR has been tested manually and two PackageTests have been added to cabal-testsuite. They pass under GHC 8.8.4 and GHC 8.10.2.

…d later

E.g. `foo/../../../bar` is now forbidden. That cannot work.

bgamari and others added 6 commits October 25, 2020 13:39

Add Distribution.Compat.Process module

2e072ed

Resolve haskell#7091: Require custom-setup for cabal-version: 1.24 an…

1515a15

…d later

phadej added this to the 3.2.1.0 milestone Oct 25, 2020

phadej added 2 commits October 25, 2020 16:24

Fix haskell#7126: Stricter checks for relative paths

246c88e

E.g. `foo/../../../bar` is now forbidden. That cannot work.

require cabal-versions >=1.25 to be exact

bf7be53

phadej force-pushed the backport-to-3.2-20201025 branch 2 times, most recently from f4791d6 to 5353990 Compare October 25, 2020 14:50

Use actions/checkout@v2

3ccf5ba

phadej force-pushed the backport-to-3.2-20201025 branch from 5353990 to 3ccf5ba Compare October 25, 2020 15:06

phadej merged commit 5c706c4 into haskell:3.2 Oct 25, 2020

phadej deleted the backport-to-3.2-20201025 branch October 25, 2020 17:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport to 3.2 20201025 #7134

Backport to 3.2 20201025 #7134

phadej commented Oct 25, 2020

Backport to 3.2 20201025 #7134

Backport to 3.2 20201025 #7134

Conversation

phadej commented Oct 25, 2020