-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tell users about cabal.project.local~ #6877
Conversation
36991d0
to
f36b53b
Compare
@@ -1,5 +1,5 @@ | |||
# cabal v2-configure | |||
'cabal.project.local' file already exists. Now overwriting it. | |||
'cabal.project.local' already exists, copying it to 'cabal.project.local~'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/copying/backuping/
.
Though I don't remember what happens when cabal.project.local~
already exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just gets overwritten it looks like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let us fix that. Otherwise we could just overwrite cabal.project.local
directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix by adding a message or by backing up cabal.project.local~ somewhere further?
f36b53b
to
74ff63d
Compare
@@ -95,7 +95,7 @@ configureAction flags@NixStyleFlags {..} _extraArgs globalFlags = do | |||
-- before overwriting | |||
exists <- doesFileExist "cabal.project.local" | |||
when exists $ do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when exists
let's search for the first one of cabal.project.local~
, cabal.project.local~0
cabal.project.local~1
etc. until one doesn't.
Note: we need to change this to take into account --project-file
as we on it. I wonder if there's an issue about that too.
-- | A custom target problem | ||
| CustomTargetProblem a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was to fix a haddock failure
55f965d
to
7357ad9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Shouldn't foo.project
however have something in it? The fact empty project file works is a not right, but fixing that is outside of scope of this PR.
7357ad9
to
32c6196
Compare
CI fails for real |
32c6196
to
f9bf6b0
Compare
CI looks green now |
Please include the following checklist in your PR:
changelog.d
directory).Please also shortly describe how you tested your change. Bonus points for added tests!