Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'optional-packages' default on missing cabal.project #6740

Merged
merged 1 commit into from
May 4, 2020

Conversation

hasufell
Copy link
Member

Fixes #6739

@phadej
Copy link
Collaborator

phadej commented Apr 25, 2020 via email

@phadej
Copy link
Collaborator

phadej commented Apr 25, 2020 via email

@hasufell
Copy link
Member Author

Apparently there are multiple references to this default: https://github.com/haskell/cabal/blob/master/Cabal/doc/cabal-project.rst

@tomjaguarpaw
Copy link
Member

Thanks for responding to my confusion. I agree that this API is better. On the other hand, I have been bitten by cabal changing its public API a few times in the past and for the sake of others I would be cautious about this going in without a very obvious warning/deprecation cycle.

@phadej
Copy link
Collaborator

phadej commented Apr 26, 2020

@tomjaguarpaw We don't have resources to manage warnings&deprecations. Either stuff is changed, or it's not. We'll try to highlight major changes in the changelog.

@phadej
Copy link
Collaborator

phadej commented Apr 26, 2020

Specifically, when people upgrade from ancient, say cabal-install-2.0 to cabal-install-3.0 they do miss deprecation warnings etc. I repeat, there is just no resources to manage warnings & deprecations with 2-3 year cycles, so people have chance to notice them. People do not upgrade cabal-install eagerly, so the 2-3 years is justified so they actually could see those warnings.

@tomjaguarpaw
Copy link
Member

As you wish. All in all, I do believe the behaviour in this PR is the better one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cabal looks inside subdirectories, but only with later GHC
3 participants