Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #6691: Remove upgrade, uninstall and win32selfupgrade commands #6707

Merged

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Apr 13, 2020

All three were hidden commands, first two were unimplemented
and the last one no-one knows about.

…commands

All three were hidden commands, first two were unimplemented
and the last one no-one knows about.
@phadej phadej merged commit eef18eb into haskell:master Apr 13, 2020
@phadej phadej deleted the issue-6691-remove-some-hidden-commands branch April 13, 2020 17:48
@23Skidoo
Copy link
Member

What's the situation with symlinks on Windows? I had the impression that win32selfupgrade is still used by cabal install cabal-install.

@phadej
Copy link
Collaborator Author

phadej commented Apr 22, 2020

By cabal v1-install cabal-install, probably, not used by v2-install. Symlinking is used on windows when it works, not universally.

@23Skidoo
Copy link
Member

Right, so I think we shouldn't remove it. v2 code might also need it for the no-symlink case (I think there was a PR or ticket about adding a file-copying fallback).

@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants