Adapt to simplified subsumption patch #6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
commented
Feb 29, 2020
| @@ -1356,7 +1356,7 @@ withTempFileEx opts tmpDir template action = | |||
| withTempDirectory :: Verbosity -> FilePath -> String -> (FilePath -> IO a) -> IO a | |||
| withTempDirectory verbosity targetDir template f = withFrozenCallStack $ | |||
| withTempDirectoryEx verbosity defaultTempFileOptions targetDir template | |||
| (withLexicalCallStack f) | |||
| (withLexicalCallStack (\x -> f x)) | |||
There was a problem hiding this comment.
@RyanGlScott I'll leave this in place, yet I'm not sure whether we need (i.e. there's any benefit) from wthFrozen/LexicalCallStack.
4 tasks
RyanGlScott
approved these changes
Feb 29, 2020
Originally written by Ryan Scott in haskell#6545 (comment)
phadej
force-pushed
the
simplified-subsumption-ryan
branch
from
87737d3 to
8dc7f0d
Compare
|
Merged. Ping @bgamari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally written by Ryan Scott in
#6545 (comment)