Fix --with-compiler failing to locate compiler on Windows
#5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to idiosyncrasies (courtesy of the `SearchPath` Win32 function) in the Windows implementation of `findExecutable` we need to explicitly try both, with and without appending the Windows specific executable extensions (i.e. `.exe`). For example, before this patch, cabal new-build -w ghc-8.6.2 would fail to find the `ghc-8.6.2.exe` even though it's on `%PATH%` and invoking ghc-8.6.2 --version on the `CMD.exe` shell would have been able to locate the executable.
|
Merged, thanks! |
23Skidoo
added a commit
that referenced
this pull request
Dec 5, 2018
Fix `--with-compiler` failing to locate compiler on Windows (cherry picked from commit c25a223)
|
Also cherry-picked into 2.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to idiosyncrasies (courtesy of the
SearchPathWin32 function) inthe Windows implementation of
findExecutablewe need to explicitly tryboth, with and without appending the Windows specific executable
extensions (i.e.
.exe).For example, before this patch,
would fail to find the
ghc-8.6.2.exeeven though it's on%PATH%andinvoking
on the
CMD.exeshell would have been able to locate the executable.