Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic smoke test for cabal sdist --list-sources #5295

Closed

Conversation

quasicomputational
Copy link
Contributor

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

By having the runner provide it (and hence know the name), it can then
normalise any paths that mention the temporary directory without a
problem.
Windows is doing something funny here. Let's find out what it is.
@quasicomputational
Copy link
Contributor Author

According to my debugging putStrLn, the contents of --list-sources on Windows is this (note mixed slashes):

.\Main.hs
data\blah/a.dat
extra-doc/blah/a.tex
.\list-sources.cabal
extra-src/blah/a.html

Since the globstar patch rewrites the affected code, I'm going to roll up this PR into #5284 and close this one and see if I incidentally fixed it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant