Add showFullInstalledPackageInfo #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
showInstalledPackageInfo uses full variant, but with pkgroot set to Nothing. This way we field descriptions have roundtrip property (wo it's simpler to proceed with reworking the parsing using parsec framework). We introduce new name, so no (coordinated) changes to ghc-pkg are needed.
23Skidoo
approved these changes
Dec 27, 2017
| @@ -359,8 +360,16 @@ parseInstalledPackageInfo = | |||
| -- ----------------------------------------------------------------------------- | |||
| -- Pretty-printing | |||
|
|
|||
| -- | Pretty print 'InstalledPackageInfo'. | |||
| -- | |||
|
Test failure is #4957. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hvr I chose to go more BC way, I'm afraid we will out of run to test ghc-pkg changes properly.
showFullInstalledPackageInfocould be removed for next Cabal / GHC-8.6 when we have better time.showInstalledPackageInfo uses full variant, but with pkgroot set to
Nothing. This way we field descriptions have roundtrip property (wo it's
simpler to proceed with reworking the parsing using parsec framework).
We introduce new name, so no (coordinated) changes to ghc-pkg are needed.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!