-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement --cabal-file, allows multiple Cabal files in directory #3553
Conversation
So |
Yes, and supporting it would require quite a bit of faffing about. |
Bikeshedding: we might want to call it /cc @dcoutts |
OK, sure (although it's hard to imagine the library getting support for hpack; it's more of a cabal-install thing.) |
I'd keep it as
note to myself: verify what automatic reconfiguration can be disabled with some flag |
Well, I have the patch to put it either way. |
Please take into account we'll also need a way to specify the |
Well... |
Alright, we'd have
but then, for consistency, I'd suggest
|
3bf5194
to
1691244
Compare
This is primarily intended for use with the Cabal test suite (allowing us to easily specify multiple Cabal packages for the same Haskell source files), but maybe some end-users will find it useful as well. If there are multiple Cabal files in the current working directory, --cabal-file (for configure) allows you to disambiguate which one to build with. There's a big hack to handle the BOM check, as it is inconvenient to plumb the flag value all the way to the check code. Some bigger refactoring needed, see haskell#3552. Signed-off-by: Edward Z. Yang <[email protected]>
1691244
to
e507ca8
Compare
@ezyang BTW, don't we need a note in the manual about |
Well, I wasn't intending for it to be a user-visible feature. If we put it in the manual, we need to teach cabal-install how to handle it too, because cabal-install also reads in cabal files itself. |
There should be a place for documenting non-user-visible features like |
Added a line to the changelog (858981e). |
This is primarily intended for use with the Cabal test suite (allowing
us to easily specify multiple Cabal packages for the same Haskell source
files), but maybe some end-users will find it useful as well. If there
are multiple Cabal files in the current working directory, --cabal-file
(for configure) allows you to disambiguate which one to build with.
There's a big hack to handle the BOM check, as it is inconvenient to
plumb the flag value all the way to the check code. Some bigger
refactoring needed, see #3552.
Signed-off-by: Edward Z. Yang [email protected]