Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print out which project file we're using by default (fix #8519) #10507

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

ulysses4ever
Copy link
Collaborator

Attempting to resurrect #8617


Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

@ulysses4ever ulysses4ever marked this pull request as draft November 3, 2024 02:13
@ulysses4ever
Copy link
Collaborator Author

Converting to a draft because of spurious changes like https://github.com/haskell/cabal/pull/10507/files#diff-d6f32a6a398cc85df21df74b2a260427387c0ea52d96987e49551137d466d92fL7 Will see what CI has to say.

@ulysses4ever
Copy link
Collaborator Author

I bet it's because the --intree-cabal-lib business...

@geekosaur
Copy link
Collaborator

I gave up on making that work when I was bisecting an issue and wanted to streamline validate a bit.

@ulysses4ever
Copy link
Collaborator Author

Okay, fixed by running with the in-tree Cabal:

❯ cabal run cabal-testsuite:cabal-tests -- --with-cabal=(cabal list-bin cabal) --accept --intree-cabal-lib $PWD --test-tmp $PWD/testdb

@ulysses4ever
Copy link
Collaborator Author

I'll put the label requesting reviews after CI is happy.

@ulysses4ever
Copy link
Collaborator Author

CI is green now. I'd like this to be considered for 3.14.1 @Kleidukos.

@ulysses4ever
Copy link
Collaborator Author

@Kleidukos @Mikolaj @ffaf1 I'd appreciate a review for this one. I'd even hope we can get it into 3.14.1. Over the years, many people have tripped over the default behavior of searching project files, and the patch could probably save some of them from it.

(The CI was green but I just pushed a changelog file, so it's rebuilding again...)

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good decision. And well tested. :)

@ulysses4ever
Copy link
Collaborator Author

Thanks! Since it's been up for 5 days, I consider the chill out period passed and apply the label manually in the interest of getting this merged in time for 3.14.1 (the final decision about addition to 3.14.1 is up to Hécate of course).

@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days and removed attention: needs-review labels Nov 7, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Nov 7, 2024
@mergify mergify bot merged commit a39266d into master Nov 7, 2024
43 checks passed
@mergify mergify bot deleted the print-current-project branch November 7, 2024 15:07
@ulysses4ever
Copy link
Collaborator Author

@mergify backport 3.14

Copy link
Contributor

mergify bot commented Nov 7, 2024

backport 3.14

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-backport 3.12 attention: needs-backport 3.14 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge re: project-file Concerning cabal.project files re: user experience User experience (UX) issue ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants