-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
round out local Makefile checks #10421
Conversation
ced4acc
to
fa3b475
Compare
I did a once-over of the "quick checks", which are currently not covered; most of those, however, either require a pristine CI-like build environment (or docker) or require unreasonable dependencies (e.g. Sphinx). The one exception is the doctests, which I'm on the fence about. There's also a question of how best to deal with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @geekosaur :)
by collecting them and adding hlint. Other checks will follow, e.g. API checking once that lands.
fa3b475
to
05e939d
Compare
Once again merged as soon as "Validate Skip / Validate post job" went green and the other branch protection rules were satisfied (mostly this means "Quick checks", which despite the name take 7-10 minutes). |
by collecting them and adding hlint. Other checks will follow, e.g. API checking once that lands.
Some other things might be added here later, and might lead to revision of various CI jobs. Consider this a start on addressing #10263 properly.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: