Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

round out local Makefile checks #10421

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

geekosaur
Copy link
Collaborator

by collecting them and adding hlint. Other checks will follow, e.g. API checking once that lands.

Some other things might be added here later, and might lead to revision of various CI jobs. Consider this a start on addressing #10263 properly.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur added attention: needs-review re: devx Improving the cabal developer experience (internal issue) labels Oct 4, 2024
@geekosaur
Copy link
Collaborator Author

I did a once-over of the "quick checks", which are currently not covered; most of those, however, either require a pristine CI-like build environment (or docker) or require unreasonable dependencies (e.g. Sphinx). The one exception is the doctests, which I'm on the fence about.

There's also a question of how best to deal with fourmolu, considering that we require 0.12 and using 0.14 will cause failures either locally or in CI.

Makefile Show resolved Hide resolved
@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 10, 2024
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Oct 10, 2024
Copy link
Collaborator

@mpickering mpickering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geekosaur :)

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 12, 2024
by collecting them and adding hlint. Other checks will follow, e.g.
API checking once that lands.
@mergify mergify bot merged commit 3dcc771 into haskell:master Oct 12, 2024
41 checks passed
@geekosaur
Copy link
Collaborator Author

Once again merged as soon as "Validate Skip / Validate post job" went green and the other branch protection rules were satisfied (mostly this means "Quick checks", which despite the name take 7-10 minutes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge re: devx Improving the cabal developer experience (internal issue) ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants