ci: Fix --index-state for hackage roundtrip tests (backport #10285) #10305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
geekosaur
approved these changes
Aug 30, 2024
As a principle, tests which are required for CI to pass should be reproducible and not depending on external resources changes or being modified. The hackage tests currently violate this by depending on the latest index state from hackage. This is problematic because until the test is fixed all merges into master are blocked. Even though the patches in question have nothing to do with the test. It would be more suitable for a nightly job to run on the latest index and for normal CI to run with a fixed index which is updated periodically in a controlled manner. Fixes #10284 (cherry picked from commit 31507b1)
geekosaur
force-pushed
the
mergify/bp/3.12/pr-10285
branch
2 times, most recently
from
62658bc
to
0e119ce
Compare
|
Welp. Guess that PR I cherry-picked doesn't actually fix it. |
geekosaur
force-pushed
the
mergify/bp/3.12/pr-10285
branch
from
0e119ce
to
7533e73
Compare
|
So random windows jobs are still failing in various ways (ghci ExitFailure, fd N:end of file, occasionally timeouts). |
|
Was there a reason this was canceled? |
(cherry picked from commit 4aade2d)
|
Cherry-picked f90d059 to try to get CI to pass. |
|
@mergify refresh |
✅ Pull request refreshed |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a principle, tests which are required for CI to pass should be
reproducible and not depending on external resources changes or being
modified. The hackage tests currently violate this by depending on the
latest index state from hackage. This is problematic because until the
test is fixed all merges into master are blocked. Even though the
patches in question have nothing to do with the test.
It would be more suitable for a nightly job to run on the latest index
and for normal CI to run with a fixed index which is updated
periodically in a controlled manner.
Fixes #10284
This is an automatic backport of pull request #10285 done by Mergify.