-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show why configuring dependencies failed #10273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I'm not qualified to determine whether this is logically correct, only that it looks reasonable (and being a spell checker 😛).
2b37276
to
310a3ed
Compare
Ah, the tests are failing because they pass the exact ID of the |
You should probably work out how to identify those and replace them with a common string in OutputNormalizer.hs |
063b848
to
dd47021
Compare
@jasagredo Fixed the tests and added a new one to demonstrate the error messages I showed off in the PR description, PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good in general 👍. I am not very knowledgeable in dependency resolution, so I cannot tell if there are other places that would need changes, but the changes that were done here look correct. Basically propagating some more information.
I added some comments, in particular I would merge those 3 new modules into Dependency.hs
, but that I guess is personal preference.
Aaaarg so sorry @9999years I accidentally pressed |
2ac79df
to
851dc03
Compare
Restored 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing a changelog entry
@fgaz Added a changelog entry, PTAL. CI failure doesn't look like it's related:
|
When `act-as-setup configure` fails, it doesn't indicate which dependencies are missing entirely and which ones don't satisfy the version constraints. The errors from `cabal build` are more informative, but aren't available in all contexts (nixpkgs Haskell builds, for example, use the `act-as-setup` interface). This makes it immediately clear what sort of dependency error has occurred. Before (cabal-install 3.12.1.0): Configuring test-pkg-0.1.0.0... Error: [Cabal-8010] Encountered missing or private dependencies: base <=4.18, foobar, test-pkg:{bar-internal, foo-internal} After: Configuring test-pkg-0.1.0.0... Error: [Cabal-8010] Encountered missing or private dependencies: base <=4.18 (installed: 4.19.1.0), foobar (missing), test-pkg:{bar-internal,foo-internal} (missing: :bar-internal)
From @geekosaur on Matrix: > since changelog-d uses the cabal file parser to parse changelog files, > internal braces have to be escaped
3d2279c
to
ec60185
Compare
This is an API change, so can't be backported to 3.12. Additionally, 3.10 is now frozen (largely because major merge conflicts will happen thanks to fourmolu) so no backports can be done to it. |
When
act-as-setup configure
fails, it doesn't indicate which dependencies are missing entirely and which ones don't satisfy the version constraints. The errors fromcabal build
are more informative, but aren't available in all contexts (nixpkgs Haskell builds, for example, use theact-as-setup
interface). This makes it immediately clear what sort of dependency error has occurred.Before (cabal-install 3.12.1.0):
After:
Please let me know if you're interested in this patch and I can write tests and polish up the documentation.
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR: