add "ready and waiting" Mergify label

[geekosaur]

The bot can use this to announce PRs that are entering the 2-day waiting period.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions). —not relevant as it is only read on master

[ffaf1]

What if then I comment on the PR? Will there be another announcement?

[geekosaur]

No, because I don't track comments and the label already exists. AIUI the point is to tell people that it's their last chance to review the PR and add any comments.

[geekosaur]

This also means there won't be a re-announcement if someone requests changes at that point and those changes are made, unless someone manually removes the label. It's probably possible to make Mergify manage that case itself, but I'm not sure it's worth doing.

[geekosaur]

BTW this isn't necessarily done. On two reviews, the new rules should trigger… but I'm unclear on whether the "(pull_request)" suffix needs to be part of the CI checks, so it may not fire. (ETA: turns out Mergify injects those rules into its own, so I could see from the Mergify tab of CI what the labels needed to be.)

[geekosaur]

@jasagredo, I think this is just waiting on your self-assigned review? Is this a bad time?

[jasagredo]

Looks good!