Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal user-config update silently enables remote-build-reporting #6210

Closed
jwaldmann opened this issue Aug 27, 2019 · 6 comments
Closed

cabal user-config update silently enables remote-build-reporting #6210

jwaldmann opened this issue Aug 27, 2019 · 6 comments
Milestone

Comments

@jwaldmann
Copy link

jwaldmann commented Aug 27, 2019

As suggested in #5973 I am doing cabal user-config update.
This silently adds a line remote-build-reporting: anonymous to the config file (while
the default setting is none).

This is with

cabal-install version 3.0.0.0
compiled using version 3.0.0.0 of the Cabal library 
@hvr
Copy link
Member

hvr commented Aug 27, 2019

I tried with cabal 1.16 (the oldest version I had locally) to see what the default generated ~/.cabal/config would look like (by invoking it for an empty new user account), and as I suspect it contained

-- build-log:
remote-build-reporting: anonymous
-- one-shot: False

Consequently, the default setting for the ~/.cabal/config file has been this way at least since cabal-install 1.16

@phadej
Copy link
Collaborator

phadej commented Aug 27, 2019

I think in Europe something like that should require explicit consent nowadays. So better to have remote-building-reporting off by default. Espcially, as I'm quite sure that the data isn't used for anything.

@phadej
Copy link
Collaborator

phadej commented Aug 27, 2019

To clarify: It's irrelevant how long the anonymous default was there. Time have gone past it, we care about our privacy.

@jwaldmann
Copy link
Author

Yes. If user-config update asked me to enable reporting (and explains what data is used by whom) I might allow it.

remote-build-reporting is not mentioned in the docs? (try https://www.haskell.org/cabal/users-guide/search.html?q=reporting&check_keywords=yes&area=default )

Also, I am a bit confused: anonymous is defined as the default value here?

installBuildReports= toFlag AnonymousReports,
But in the auto-generated config file, the line is remote-build-reporting: anonymous, not -- remote-build-reporting: anonymous, so I thought that the value shown is not the default.

@gbaz
Copy link
Collaborator

gbaz commented Aug 28, 2019

I think this flag was added optimistically and isn't actually set to do anything at the moment? If we actually add a feature to go with it, we'll need to probably make the opt-in genuinely explicit, even though this flag was auto-set for people.

m-renaud added a commit to m-renaud/cabal that referenced this issue Mar 30, 2020
@phadej
Copy link
Collaborator

phadej commented Apr 1, 2020

I think 6625 fixed this.

@phadej phadej closed this as completed Apr 1, 2020
@phadej phadej mentioned this issue Apr 1, 2020
m-renaud added a commit to m-renaud/cabal that referenced this issue Apr 2, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants