Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured hash tests are not invariant on GHC version #10269

Closed
mpickering opened this issue Aug 21, 2024 · 0 comments · Fixed by #10270
Closed

Structured hash tests are not invariant on GHC version #10269

mpickering opened this issue Aug 21, 2024 · 0 comments · Fixed by #10270
Assignees
@mpickering
Labels
needs triage type: bug

Comments

@mpickering
Copy link
Collaborator

Related to #10263

Currently the structured hash test is annoying to update as it produces different results on different GHC versions.

The reason for this is the Generic instance for (,) changed in 9.8 (https://gitlab.haskell.org/ghc/ghc/-/issues/24291)

We can fix this issue by not relying on the Generic instance for tuples.
@mpickering mpickering self-assigned this Aug 21, 2024
mpickering added a commit that referenced this issue Aug 21, 2024
@mpickering
tests: Make structured hash tests invariant to GHC version
63895af 
In 9.8 the Generic instance for tuples changed (see
https://gitlab.haskell.org/ghc/ghc/-/issues/24291) for more details.

Therefore we remove the dependency on the `Generic` instance and the
hashes will be invariant across GHC versions (for now).

Fixes #10269
@mpickering mpickering mentioned this issue Aug 21, 2024
Merged
2 tasks
mpickering added a commit that referenced this issue Aug 21, 2024
@mpickering
tests: Make structured hash tests invariant to GHC version
3fb0a3d 
In 9.8 the Generic instance for tuples changed (see
https://gitlab.haskell.org/ghc/ghc/-/issues/24291) for more details.

Therefore we remove the dependency on the `Generic` instance and the
hashes will be invariant across GHC versions (for now).

Fixes #10269
mpickering added a commit that referenced this issue Aug 21, 2024
@mpickering
tests: Make structured hash tests invariant to GHC version
7a69615 
In 9.8 the Generic instance for tuples changed (see
https://gitlab.haskell.org/ghc/ghc/-/issues/24291) for more details.

Therefore we remove the dependency on the `Generic` instance and the
hashes will be invariant across GHC versions (for now).

Fixes #10269
@mergify mergify bot closed this as completed in #10270 Aug 25, 2024
@mergify mergify bot closed this as completed in b90ccb3 Aug 25, 2024
erikd pushed a commit to erikd/cabal that referenced this issue Jan 9, 2025
@mpickering @erikd
tests: Make structured hash tests invariant to GHC version
c34d821 
In 9.8 the Generic instance for tuples changed (see
https://gitlab.haskell.org/ghc/ghc/-/issues/24291) for more details.

Therefore we remove the dependency on the `Generic` instance and the
hashes will be invariant across GHC versions (for now).

Fixes haskell#10269
erikd pushed a commit to erikd/cabal that referenced this issue Jan 9, 2025
@mpickering @erikd
tests: Make structured hash tests invariant to GHC version
a79abf2 
In 9.8 the Generic instance for tuples changed (see
https://gitlab.haskell.org/ghc/ghc/-/issues/24291) for more details.

Therefore we remove the dependency on the `Generic` instance and the
hashes will be invariant across GHC versions (for now).

Fixes haskell#10269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpickering mpickering

Labels
needs triage type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Make structured hash tests invariant to GHC version haskell/cabal
1 participant
@mpickering