Skip to content

Commit

Permalink
[ mergify ] require 2 days to pass after last update of PR to merge it
Browse files Browse the repository at this point in the history
Co-authored-by: Mikolaj Konarski <[email protected]>
  • Loading branch information
ulysses4ever and Mikolaj committed Jul 13, 2022
1 parent 1fcf56a commit ccdfcc0
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/mergify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ pull_request_rules:
conditions:
- label=merge me
- '#approved-reviews-by>=2'
- updated-at<2 days ago
# merge+squash strategy
- actions:
queue:
Expand All @@ -23,6 +24,7 @@ pull_request_rules:
conditions:
- label=squash+merge me
- '#approved-reviews-by>=2'
- updated-at<2 days ago

queue_rules:
- name: default
Expand Down
16 changes: 15 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ We like [this style guide][guide].

[guide]: https://github.com/tibbe/haskell-style-guide/blob/master/haskell-style.md

GitHub conventions
GitHub Tickets Conventions
-------------------

Each major `Cabal`/`cabal-install` release (e.g. 3.4, 3.6, etc.) has a
Expand All @@ -197,6 +197,20 @@ accepting a fix in that release, i.e. we would very much appreciate someone
working on it, but are not committing to actively sourcing someone to work on
it.

GitHub Pull Requests Conventions
-------------------

Every (non-backport) pull request has to go through a review and get 2 approvals. After
this is done, the author of the pull request is expected to add any final touches they
deem important and put the `merge me` label on the pull request. If the author lacks
permissions to apply labels, they are welcome to explicitly signal the merge intent on the discussion thread of the
pull request, at which point others (e.g., reviewers) apply the label. Merge buttons are reserved for exceptional
situations, e.g., CI fixes being iterated on or backports/patches that need to be expedited for a release.

Currently there is a 2 day buffer for potential extra feedback between the last update of a pull request (e.g.
a commit, a rebase, an addition of the `merge me` label) and the moment the Mergify bot picks up the pull
request for a merge.

Changelog
---------

Expand Down

0 comments on commit ccdfcc0

Please sign in to comment.