Skip to content

Commit

Permalink
cabal-install: Fix the directory the build folder is created in
Browse files Browse the repository at this point in the history
Clearly this path needs to be relative to the CWD, and the correct
offset is passed as the `srcdir` parameter.

Fixes #10772
  • Loading branch information
mpickering committed Feb 26, 2025
1 parent 380aaa7 commit c257a30
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ buildInplaceUnpackedPackage
-- TODO: [code cleanup] there is duplication between the
-- distdirlayout and the builddir here builddir is not
-- enough, we also need the per-package cachedir
createDirectoryIfMissingVerbose verbosity True $ getSymbolicPath builddir
createDirectoryIfMissingVerbose verbosity True $ interpretSymbolicPath (Just srcdir) builddir
createDirectoryIfMissingVerbose
verbosity
True
Expand Down
12 changes: 12 additions & 0 deletions changelog.d/pr-10800
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
synopsis: Fix regression where 'build' folder was created in CWD when running a standlone script.
packages: cabal-install
prs: #10800
issues: #10772
significance:

description: {

Fix a regression where the `build` folder was created in the current directory
when running a standalone script.

}

0 comments on commit c257a30

Please sign in to comment.