Skip to content

Commit

Permalink
don't use tasty-quickcheck 0.11
Browse files Browse the repository at this point in the history
tasty-quickcheck 0.11 breaks backward compatibility. We don't have any
upper bounds on it.
  • Loading branch information
geekosaur committed Jun 22, 2024
1 parent 58b8126 commit 2cb6ea5
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 48 deletions.
42 changes: 1 addition & 41 deletions .github/mergify.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# Note: We do not use the rebase strategy to merge PRs, because that
# loses information needed by changelog-d to associate commits with PRs.

pull_request_rules:

# implementing PR delay logic: apply a label after 2 days of inactivity
Expand Down Expand Up @@ -32,7 +29,6 @@ pull_request_rules:
- label=merge me
- label=merge delay passed
- '#approved-reviews-by>=2'
- '-label~=^blocked:'

# merge+squash strategy
- actions:
Expand All @@ -48,7 +44,6 @@ pull_request_rules:
- label=squash+merge me
- label=merge delay passed
- '#approved-reviews-by>=2'
- '-label~=^blocked:'

# merge+no rebase strategy
- actions:
Expand All @@ -60,41 +55,8 @@ pull_request_rules:
- label=merge+no rebase
- label=merge delay passed
- '#approved-reviews-by>=2'
- '-label~=^blocked:'

# merge strategy for release branches
- actions:
queue:
name: default
# Merge with a merge commit
method: merge
# Update the pr branch with rebase, so the history is clean
update_method: rebase
name: Put release branch pull requests in the rebase+merge queue
conditions:
- label=merge me
- base!=master
- -body~=backport
- '#approved-reviews-by>=2'
- '-label~=^blocked:'

# merge+squash strategy for release branches
- actions:
queue:
name: default
method: squash
# both update methods get absorbed by the squash, so we use the most
# reliable
update_method: merge
name: Put release branch pull requests in the squash+merge queue
conditions:
- base!=master
- label=squash+merge me
- -body~=backport
- '#approved-reviews-by>=2'
- '-label~=^blocked:'

# merge strategy for backports: require 1 approver instead of 2
# rebase+merge strategy for backports: require 1 approver instead of 2
- actions:
queue:
name: default
Expand All @@ -108,7 +70,6 @@ pull_request_rules:
- base!=master
- body~=backport
- '#approved-reviews-by>=1'
- '-label~=^blocked:'

# merge+squash strategy for backports: require 1 approver instead of 2
- actions:
Expand All @@ -124,7 +85,6 @@ pull_request_rules:
- base!=master
- body~=backport
- '#approved-reviews-by>=1'
- '-label~=^blocked:'

# backports should be labeled as such
- actions:
Expand Down
4 changes: 2 additions & 2 deletions Cabal-described/Cabal-described.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ library
, pretty
, QuickCheck
, rere >=0.1 && <0.3
, tasty
, tasty-quickcheck
, tasty <1.6
, tasty-quickcheck <0.11

exposed-modules:
Distribution.Described
Expand Down
4 changes: 2 additions & 2 deletions Cabal-tests/Cabal-tests.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ test-suite unit-tests
, QuickCheck >=2.14 && <2.15
, tasty >=1.2.3 && <1.6
, tasty-hunit
, tasty-quickcheck
, tasty-quickcheck <0.11
, temporary
, text

Expand Down Expand Up @@ -176,7 +176,7 @@ test-suite rpmvercmp
QuickCheck
, tasty >=1.2.3 && <1.6
, tasty-hunit
, tasty-quickcheck
, tasty-quickcheck <0.11

c-sources: tests/cbits/rpmvercmp.c
cc-options: -Wall
Expand Down
2 changes: 1 addition & 1 deletion cabal-install-solver/cabal-install-solver.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -135,5 +135,5 @@ Test-Suite unit-tests
, Cabal-syntax
, cabal-install-solver
, tasty >= 1.2.3 && <1.6
, tasty-quickcheck
, tasty-quickcheck <0.11
, tasty-hunit >= 0.10
4 changes: 2 additions & 2 deletions cabal-install/cabal-install.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ test-suite unit-tests
zlib,
tasty >= 1.2.3 && <1.6,
tasty-golden >=2.3.1.1 && <2.4,
tasty-quickcheck,
tasty-quickcheck <0.11,
tasty-expected-failure,
tasty-hunit >= 0.10,
tree-diff,
Expand Down Expand Up @@ -438,6 +438,6 @@ test-suite long-tests
tasty >= 1.2.3 && <1.6,
tasty-expected-failure,
tasty-hunit >= 0.10,
tasty-quickcheck,
tasty-quickcheck <0.11,
QuickCheck >= 2.14 && <2.16,
pretty-show >= 1.6.15

0 comments on commit 2cb6ea5

Please sign in to comment.