Skip to content

Commit

Permalink
Cabal-3.2 knows GHC-8.10
Browse files Browse the repository at this point in the history
  • Loading branch information
phadej committed Feb 3, 2020
1 parent 6e9d6bd commit 1a31242
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Cabal/Distribution/Simple/GHC.hs
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,11 @@ configure verbosity hcPath hcPkgPath conf0 = do
(userMaybeSpecifyPath "ghc" hcPath conf0)
let implInfo = ghcVersionImplInfo ghcVersion

-- Cabal currently supports ghc >= 7.0.1 && < 8.10
unless (ghcVersion < mkVersion [8,10]) $
-- Cabal currently supports ghc >= 7.0.1 && < 8.12
unless (ghcVersion < mkVersion [8,12]) $
warn verbosity $
"Unknown/unsupported 'ghc' version detected "
++ "(Cabal " ++ prettyShow cabalVersion ++ " supports 'ghc' version < 8.10): "
++ "(Cabal " ++ prettyShow cabalVersion ++ " supports 'ghc' version < 8.12): "
++ programPath ghcProg ++ " is version " ++ prettyShow ghcVersion

-- This is slightly tricky, we have to configure ghc first, then we use the
Expand Down
1 change: 1 addition & 0 deletions release-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@
`supportedGHCVersions` (`Distribution.Simple.Program.GHC`)
- Update `Language.Haskell.Extension` list, if there are new GHC extensions
- Update `setupMinCabalVersionConstraint` (in `Distribution.Client.ProjectPlanning`)
- Update `Cabal.Distribution.Simple.GHC` to include new GHC version

0 comments on commit 1a31242

Please sign in to comment.