Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhencing trace info of char #252

Merged
merged 3 commits into from
Dec 30, 2023
Merged

enhencing trace info of char #252

merged 3 commits into from
Dec 30, 2023

Conversation

ZichaoNickFox
Copy link

image
Adding char after char order. For improving debug experience.

@ZichaoNickFox ZichaoNickFox deleted the enhence_trace_info branch November 17, 2023 07:33
@ZichaoNickFox ZichaoNickFox restored the enhence_trace_info branch November 17, 2023 07:43
@ZichaoNickFox ZichaoNickFox reopened this Nov 17, 2023
@ZichaoNickFox
Copy link
Author

ZichaoNickFox commented Nov 17, 2023 •
edited
Loading

Hello. I am not sure my change is suitable, and my understand is right.
Why alexGetByte :: AlexInput -> Maybe (Char, AlexInput) can fetch Char as document said.
image
While template needs alexGetByte returns Just (Integral, AlexInput) as follow.
image

@andreasabel andreasabel self-assigned this Dec 30, 2023
@andreasabel andreasabel added this to the 3.4.1.0 milestone Dec 30, 2023
@andreasabel
Copy link
Member

I fixed the missing import Data.Char (chr) and added testing for --debug to the testsuite.

@andreasabel andreasabel merged commit 4f43962 into haskell:master Dec 30, 2023
25 checks passed
@ZichaoNickFox ZichaoNickFox deleted the enhence_trace_info branch January 23, 2024 05:53
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 12, 2024
@0-wiz-0
alex: update to 3.5.1.0.
9df635a 
## Changes in 3.5.1.0

* Drop generating output for GHC < 6.4.
* Use qualified imports in generated code (except for `Prelude`)
  ([Issue #258](haskell/alex#258)).
* Suppress warnings `tabs` and `unused-imports` for generated code
  ([Issue #255](haskell/alex#255)).
* Tested with GHC 8.0 - 9.8.2.

## Changes in 3.5.0.0

 * Add option `--numeric-version`.
 * Remove deprecated `-v` as alias for `--version`.
 * Add `-v` as placeholder for a future `--verbose` option.
 * Make `alex{G,S}etUserState` available with the `monadUserState-bytestring` wrapper
   ([Issue #220](haskell/alex#220)).
 * Debugging lexer: print character in addition to its ASCII code
   ([PR #252](haskell/alex#252)).
 * Tested with GHC 8.0 - 9.8.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andreasabel andreasabel

Labels
None yet
Projects
None yet
Milestone
3.5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ZichaoNickFox @andreasabel