Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Data.Attoparsec.Number instances #998

Closed
phadej opened this issue Feb 10, 2023 · 0 comments
Closed

Drop Data.Attoparsec.Number instances #998

phadej opened this issue Feb 10, 2023 · 0 comments
Labels
versioning level: major/breaking
Milestone
2.2

Comments

@phadej
Copy link
Collaborator

phadej commented Feb 10, 2023

No description provided.

@phadej phadej added this to the 2.2 milestone Feb 10, 2023
phadej added a commit that referenced this issue Jun 9, 2023
@phadej
Resolve #998. Drop attoparsec.Number instances.
2e4dddb 
More fore: Drop `attoparsec` dependency alltogether.

We parse scientific from Text manually now.
Notice, `scientific` parser in `attoparsec` is quadratic (uses
`decimal`).
phadej added a commit that referenced this issue Jun 9, 2023
@phadej
Resolve #998. Drop attoparsec.Number instances.
0ef3641 
More fore: Drop `attoparsec` dependency alltogether.

We parse scientific from Text manually now.
Notice, `scientific` parser in `attoparsec` is quadratic (uses
`decimal`).
haskell/attoparsec#217
phadej added a commit that referenced this issue Jun 9, 2023
@phadej
Resolve #998. Drop attoparsec.Number instances.
bb36c0d 
More fore: Drop `attoparsec` dependency alltogether.

We parse scientific from Text manually now.
Notice, `scientific` parser in `attoparsec` is quadratic (uses
`decimal`).
haskell/attoparsec#217
phadej added a commit that referenced this issue Jun 9, 2023
@phadej
Resolve #998. Drop attoparsec.Number instances.
629b88d 
More fore: Drop `attoparsec` dependency alltogether.

We parse scientific from Text manually now.
Notice, `scientific` parser in `attoparsec` is quadratic (uses
`decimal`).
haskell/attoparsec#217
@phadej phadej closed this as completed in 6d07a16 Jun 9, 2023
phadej added a commit that referenced this issue Jun 9, 2023
@phadej
Merge pull request #1037 from haskell/issue-998
a0e735f 
Resolve #998. Drop attoparsec.Number instances.
JonathanLorimer pushed a commit to JonathanLorimer/aeson that referenced this issue Aug 7, 2023
@phadej @JonathanLorimer
Resolve haskell#998. Drop attoparsec.Number instances.
1785ef0 
More fore: Drop `attoparsec` dependency alltogether.

We parse scientific from Text manually now.
Notice, `scientific` parser in `attoparsec` is quadratic (uses
`decimal`).
haskell/attoparsec#217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
versioning level: major/breaking
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
1 participant
@phadej