Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call mmap through a C helper #96

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions cbits/mmap.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
/*
Copyright Colin Watson 2015

All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.

* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following
disclaimer in the documentation and/or other materials provided
with the distribution.

* Neither the name of Colin Watson nor the names of other
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

#include <sys/mman.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IANAL, but I seriously doubt such a trivial wrapper is even (c)-able at all :-)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. There's nothing here to copyright.


void *hashable_mmap(void *addr, size_t length, int prot, int flags,
int fd, off_t offset)
{
return mmap(addr, length, prot, flags, fd, offset);
}
1 change: 1 addition & 0 deletions hashable.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ Test-suite tests
if !os(windows)
Build-depends: unix
CPP-options: -DHAVE_MMAP
C-sources: cbits/mmap.c
Other-modules: Regress.Mmap

Ghc-options: -Wall -fno-warn-orphans
Expand Down
2 changes: 1 addition & 1 deletion tests/Regress/Mmap.hsc
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ mprotect :: Ptr a -> CSize -> CInt -> IO ()
mprotect addr len prot =
throwErrnoIfMinus1_ "mprotect" $ c_mprotect addr len prot

foreign import ccall unsafe "sys/mman.h mmap"
foreign import ccall unsafe "hashable_mmap"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use the capi FFI calling-convention which was invented exactly for this use case to avoid having to write such trivial wrappers as in cbits/mmap.c?

c_mmap :: Ptr a -> CSize -> CInt -> CInt -> CInt -> COff -> IO (Ptr a)

foreign import ccall unsafe "sys/mman.h munmap"
Expand Down