Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lower bounds #895

Merged
merged 2 commits into from
Jan 25, 2018
Merged

Bump lower bounds #895

merged 2 commits into from
Jan 25, 2018

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Jan 25, 2018


@alp and other @haskell-servant/maintainers: I'd like to try this bounds schema. It's less aggressive than "lowest versions there is build-plan for", but lessens maintaining burden (we have e.g. MIN_VERSION_http_types and MIN_VERSION_wai_app_static now, which I'd like to get rid off, we really don't test "other branch" that well)

@phadej phadej requested a review from alpmestan January 25, 2018 09:31
@phadej phadej added this to the 0.13 milestone Jan 25, 2018
@phadej phadej force-pushed the lower-bounds branch 2 times, most recently from 470a207 to 984d491 Compare January 25, 2018 09:37
@fizruk
Copy link
Member

fizruk commented Jan 25, 2018

Looks good! And now I learned that it's possible to have multiple build-depends sections! :)

@alpmestan
Copy link
Contributor

CI is not happy, but I'm otherwise not opposed to the new bounds.

@phadej
Copy link
Contributor Author

phadej commented Jan 25, 2018

Good. I'll go through the rest of packages, and then merge (when travis is happy)

Copy link
Contributor

@alpmestan alpmestan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for when CI is green)

@phadej phadej force-pushed the lower-bounds branch 2 times, most recently from 208df4b to e89b0e3 Compare January 25, 2018 11:50
- `text` is already 1.2.3.0 as commercialhaskell/stackage#3147
  is resolved AFAICS

- `http-types` bound is surprisingly low due:
  commercialhaskell/stackage#2976
@phadej phadej changed the title Bump lower bounds in servant Bump lower bounds Jan 25, 2018
@phadej phadej force-pushed the lower-bounds branch 2 times, most recently from 6994a14 to 114ddfb Compare January 25, 2018 13:37
@phadej phadej merged commit 030cbbc into haskell-servant:master Jan 25, 2018
@phadej phadej deleted the lower-bounds branch January 25, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants