Add new Servant.API.Range type
#1805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchoutri
requested changes
Feb 14, 2025
There was a problem hiding this comment.
Could you please add a a test case to https://github.com/haskell-servant/servant/blob/master/servant-client/test/Servant/ClientTestUtils.hs that makes use of it?
|
Thanks a lot @kutyel! Could you please add a changelog entry in https://github.com/haskell-servant/servant/tree/master/changelog.d ? |
kutyel
changed the title
Servant.API.BoundedNat type
tchoutri
requested changes
Feb 14, 2025
kutyel
changed the title
Servant.API.BoundedNat typeServant.API.Range type
|
Can I ping @haskell-servant/maintainers for review? 🙏🏻 |
tchoutri
requested changes
Feb 19, 2025
tchoutri
approved these changes
Feb 19, 2025
|
@arianvp 🙏🏻 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Scrive we are using this type quite extensively, so I thought it might be a good idea to contribute it back to Servant. Please, let me know which docs or other files am I missing so that this contribution is useful for the servant community and also let me know if you would like to have this as part of the library or not. Thanks in advance!