Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare servant-quickcheck-0.1.0.0 #1760

Merged
merged 3 commits into from
May 17, 2024

Conversation

tchoutri
Copy link
Contributor

@tchoutri tchoutri commented May 17, 2024

This PR prepares the release of servant-quickcheck-0.1.0.0:

  • Add missing LICENSE file to servant-quickcheck

closes #1757

blocks commercialhaskell/stackage#7391

@tchoutri tchoutri requested a review from maksbotan May 17, 2024 07:45
@tchoutri tchoutri force-pushed the prepare-servant-quiccheck-0.1.0.0-release branch from b25febe to ac8c58a Compare May 17, 2024 08:03
@tchoutri tchoutri force-pushed the prepare-servant-quiccheck-0.1.0.0-release branch from ac8c58a to 866ad21 Compare May 17, 2024 08:36
@maksbotan
Copy link
Contributor

@tchoutri CI failed?

@tchoutri tchoutri force-pushed the prepare-servant-quiccheck-0.1.0.0-release branch from 866ad21 to ffdfeb2 Compare May 17, 2024 10:52
@tchoutri
Copy link
Contributor Author

@maksbotan review welcome. :)

@maksbotan maksbotan merged commit 60bd041 into master May 17, 2024
7 checks passed
@maksbotan
Copy link
Contributor

Great, thanks!

Please try this candidate on Hackage before I release it: https://hackage.haskell.org/package/servant-quickcheck-0.1.0.0/candidate/servant-quickcheck-0.1.0.0.tar.gz

I checked that it works with current Hackage versions of servant*, but maybe I've missed something.

After that we'll need a PR with quickcheck bump in other servant repos.

@ysangkok ysangkok deleted the prepare-servant-quiccheck-0.1.0.0-release branch May 17, 2024 16:39
@maksbotan maksbotan mentioned this pull request May 17, 2024
@tchoutri
Copy link
Contributor Author

@maksbotan I don't see anything shifty with it. We can probably pull the lever

@maksbotan
Copy link
Contributor

Super! I've made a release on hackage.

@tchoutri
Copy link
Contributor Author

tchoutri commented May 20, 2024

@maksbotan while we're bumping bounds, do you need help for the openapi3{,-servant} packages? I have work time allocated for this kind of tasks.

@maksbotan
Copy link
Contributor

If you prepare PRs with bumps, thar would be nice!

Better all recent bumps (lens, etc) in one PR, to save us both some work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare servant-quickcheck 1.0 release
2 participants