Changes to Shorthands #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that it is used in list as fmap mkConst `[1, null, 2 ...]`
Anton-Latukha
force-pushed
the
2021-07-09-changes
branch
from
2437414 to
65a56cd
Compare
M src/Nix/Expr/Shorthands.hs
Anton-Latukha
force-pushed
the
2021-07-09-changes
branch
from
fc09dda to
88cbafc
Compare
Anton-Latukha
force-pushed
the
2021-07-09-changes
branch
from
88cbafc to
52f117c
Compare
Nix has 14 levels, Haskell has 9, so relatively translated it, but may need more tweaking.
All tests are preserved & work the same way. The variadic functions were constructed to make test reviewing & adding more straight-forward (hopefully).
Anton-Latukha
force-pushed
the
2021-07-09-changes
branch
from
52f117c to
bef95eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walked into the
Shorthandsmodule.Main things: https://github.com/haskell-nix/hnix/blob/2021-07-09-changes/ChangeLog.md
mkAssertParserTests.@.<|>operator that represents (previously unrepresentable by shorthands) feature of a language:s.x or y.