Split core into multiple packages #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split from `-core` so it doesn't depend on quickcheck, generic-arbitrary and quickcheck-instances that could propagate downstrem. Also allows users to defined their own. With all roundtrip property tests. Later this should also absorb test nix-store/daemon harness from `-remote` so it can be reused by others.
One year late hah. Thanks Anton!
bump for remote
Ericson2314
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
I didn't read this all by any means, but from talking with @sorki and glancing it over it seems to be the right idea
|
Need to practice small-er PRs so I'll open another one for NAR/readonly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-tests-narIntegratehnix-store-benchmarkfrom #26 andhnix-store-dumpas executables #233-readonlySplit offReadonlyStoreinto hnix-store-readonly #235will follow