Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rss-3000.2.0.6 breaks in some configurations due to SafeHaskell #7

Open
hvr opened this issue Jan 3, 2017 · 1 comment
Open

rss-3000.2.0.6 breaks in some configurations due to SafeHaskell #7

hvr opened this issue Jan 3, 2017 · 1 comment

Comments

@hvr
Copy link
Collaborator

hvr commented Jan 3, 2017

I've noticed this with the default install-plans of GHC 7.4/7.6 (but not with GHC < 7.4 or GHC >= 7.8) and it looks like:

Preprocessing library rss-3000.2.0.6...
[1 of 1] Compiling Text.RSS         ( Text/RSS.hs, /tmp/rss-3000.2.0.6/dist-newstyle/build/x86_64-linux/ghc-7.4.2/rss-3000.2.0.6/build/Text/RSS.o )

Text/RSS.hs:67:1:
    Data.Time.Clock: Can't be safely imported!
    The module itself isn't safe.

Text/RSS.hs:68:1:
    Data.Time.Format: Can't be safely imported!
    The module itself isn't safe.

After a bit more investigation, this appears to be a problem with the time < 1.4.2 range (and only for GHC >= 7.4); but I'm still investigating (this commit here for which time-1.4.2 was the first release to contain it seems relevant: haskell/time@7cc0d01)

hvr added a commit to haskell/hackage-server that referenced this issue Mar 20, 2017
and also try to workaround GHC 7.6.3 issue w/ rss-3000.2.0.6
(see haskell-hvr/rss#7)
@hvr
Copy link
Collaborator Author

hvr commented Feb 4, 2018

Things got worse it seems (this is now affecting also GHC 8.2.2):

Configuring rss-3000.2.0.6...
Preprocessing library for rss-3000.2.0.6..
Building library for rss-3000.2.0.6..
[1 of 1] Compiling Text.RSS         ( Text/RSS.hs, dist/build/Text/RSS.o )

Text/RSS.hs:59:1: error:
    Network.URI: Can't be safely imported!
    The module itself isn't safe.
   |
59 | import Network.URI (URI)
   | ^^^^^^^^^^^^^^^^^^^^^^^^

IMO, the easiest way would be to revert back to {-# LANGUAGE Trustworthy #-} (i.e. what rss-3000.2.0.5 did) and silence the resulting SafeHaskell compile warnings...

hvr added a commit to haskell/hackage-server that referenced this issue Feb 4, 2018
hvr added a commit that referenced this issue Oct 6, 2018
This also addresses #7 by switching from Safe to Trustworthy level
as not all dependencies we depend upon weren't SafeHaskell-clean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant