wip: Fix build with cabal-2.4

[jtojnar]

Closes: #15

[juhp]

This fixes the build for me, thanks

[jtojnar]

Note that this is not a right way to do this, see haskell/cabal#5284 (comment)

[juhp]

Thanks, can cabalVersion not be used for this?

[jtojnar]

If I recall correctly, it needs to be not the version of Cabal but of the spec listed in the cabal file. It should be routed similarly to this: https://github.com/google/proto-lens/pull/242/files#diff-4fe9daabe5a3a972435eb21087de0259R183

[juhp]

Okay, I am trying to get my head around this - would the Cabal lib linked by the hgettext lib and Setup not provide the correct cabalVersion anyway?

[jtojnar]

If I recall correctly, you declare glob patterns in x-gettext-po-files field in the cabalfile for the Setup.hs hook to find the files. Glob pattern parsing is version dependent and for other fields like data-files it is controlled by the spec version set by cabal-version, you would probably want the same for x-gettext-po-files. This PR currently fixes the glob style to one used by the 2.0 spec.

You definitely do not want to have it change based on the cabal version the user runs, which is what cabalVersion returns, as far as I understand it.

[juhp]

You definitely do not want to have it change based on the cabal version the user runs, which is what cabalVersion returns, as far as I understand it.

Okay thank you for the explanation, that does make sense.