Fix for exception on hanging doublequote #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreasabel @phadej Any updates on this simple fix for a nasty bug (caused by use of partial function |
Test case `escapedMalformed0` is failing, throwing uncaught `error`
yitz-zoomin
force-pushed
the
bugfix/exception-on-hanging-doublequote
branch
from
8feec3e to
a4627a6
Compare
yitz-zoomin
force-pushed
the
bugfix/exception-on-hanging-doublequote
branch
from
47d7eb5 to
c7bdbca
Compare
|
Tests are failing, e.g. https://github.com/haskell-hvr/cassava/actions/runs/7400077740/job/20151432820?pr=222#step:20:84
Building the tests also fails, e.g. https://github.com/haskell-hvr/cassava/actions/runs/7400077740/job/20151434424?pr=222#step:19:34
|
andreasabel
added
the
re: error reporting
andreasabel
added a commit
that referenced
this pull request
Aug 3, 2024
andreasabel
pushed a commit
that referenced
this pull request
Aug 3, 2024
Squashed from commits: - task: add test cases for decoding escaped input Test case `escapedMalformed0` is failing, throwing uncaught `error` - fix: handle case when input for field parser is a single opening double-quote - Fix output of escapedMalformed1 test (this contribution got deleted) - Fixup PR #222: remove failing test, drop testing for GHC < 8.4 Co-authored-by: German Zhyvotnikov <[email protected]>
Merged
|
Fixup of this PR in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There's a problem with escaped fields parser, -- it is partial on opening double quote. Means, it throws Haskell
errorinstead of properly failing. The problem is because of ByteString.init being called on possibly empty bytestring (w/o checking). This small PR suggest a fix for this, plus adds some tests for decoding of escaped input.