Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix SDL_CONTROLLERAXISMOTION/ControllerAxisEvent #218

Merged
merged 1 commit into from
Oct 28, 2020
Merged

fix SDL_CONTROLLERAXISMOTION/ControllerAxisEvent #218

merged 1 commit into from
Oct 28, 2020

Conversation

nxths
Copy link
Contributor

@nxths nxths commented Jun 5, 2020

Was wondering why ControllerAxisEvent never fired, but moving gamepad analog sticks seemed to send ControllerButtonEvent. This fixes that behavior, tested manually.

@expipiplus1
Copy link
Contributor

Is it possible to get this merged, please?

@ocharles
Copy link
Member

This looks reasonable to me.

@ocharles ocharles merged commit 92bcddd into haskell-game:master Oct 28, 2020
@ocharles
Copy link
Member

ocharles commented Oct 28, 2020 via email

@expipiplus1
Copy link
Contributor

Thanks!

@ocharles
Copy link
Member

ocharles commented Nov 2, 2020

Sorry, didn't quite make the promise of "tomorrow", but this is now on Hackage as 2.5.3.0. On the one hand it's a technically breaking change, but I couldn't quite bring myself to submit a major version bump. Hope everyone is ok with this versioning.

@nxths nxths deleted the fix_controller_axis_event branch November 2, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nxths @expipiplus1 @ocharles @incoherentsoftware