Enhance Database.Beam.Migrate.Simple #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello there... sorry for the long delay. I think this is a good change, but I worry that |
kmicklas
reviewed
Jun 10, 2020
There was a problem hiding this comment.
@tathougies Unless I'm missing something, it looks like autoMigrate will still fail on an unsafe migration.
| @@ -211,18 +215,54 @@ autoMigrate :: (Database be db, Fail.MonadFail m) | |||
| => BeamMigrationBackend be m | |||
| -> CheckedDatabaseSettings be db | |||
| -> m () | |||
| autoMigrate BeamMigrationBackend { backendActionProvider = actions | |||
| , backendGetDbConstraints = getCs } | |||
| autoMigrate b@(BeamMigrationBackend {}) | |||
There was a problem hiding this comment.
I don't think this needs @(BeamMigrationBackend {})?
| Candidates {} -> Fail.fail "planMigration: Could not determine migration" | ||
| Solved cmds -> return cmds | ||
|
|
||
| describeMigrationPlan :: Sql92DisplaySyntax (BeamSqlBackendSyntax be) |
There was a problem hiding this comment.
The type signature and implementation of this are both pretty specific to the use in autoMigrateVerbose. I think we should not export it.
| -- Check if any of the commands are irreversible | ||
| case foldMap migrationCommandDataLossPossible cmds of | ||
| MigrationKeepsData -> mapM_ (runNoReturn . migrationCommand) cmds | ||
| _ -> Fail.fail "executeMigrationPlan: Not performing automatic migration due to data loss" |
There was a problem hiding this comment.
nit: this should match MigrationKeepsData explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From obsidiansystems@5f73965