Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop GHC-7 support, Ubuntu Bionic&Xenial; Add Noble Numbat #720

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented May 1, 2024

Resolves #719

@phadej phadej merged commit a4f50ce into master May 1, 2024
10 checks passed
@phadej phadej deleted the noble branch May 1, 2024 12:40
@liskin
Copy link

liskin commented May 5, 2024

Is it intentional that haskell-ci silently stops generating CI matrix entries for GHC 7.* without any warning/error whatsoever, despite those being mentioned in tested-with?

liskin added a commit to liskin/xmonad-maintenance that referenced this pull request May 5, 2024
@phadej
Copy link
Collaborator Author

phadej commented May 5, 2024

Is it intentional that haskell-ci silently stops generating CI matrix entries for GHC 7.* without any warning/error whatsoever, despite those being mentioned in tested-with?

Unfortunately it's how haskell-ci works. We specify a version range for GHC versions; if today you write tested-with: GHC >=10 you won't get none, with GHC >=7.0 you'll get all (incl all minor versions, i.e. a lot).

OTOH, the

*INFO* Generating GitHub config for testing for GHC versions: 8.0.2 8.2.2 8.4.4 8.6.5 8.8.4 8.10.7 9.0.2 9.2.8 9.4.7 9.6.3 9.8.1

output is almos the only thing haskell-ci outputs, so should be easy to spot if something as off; and obviously git diff before you commit the changes.

So I don't see that "silence" as a major problem.

@liskin
Copy link

liskin commented May 5, 2024

Oh, I didn't realise you can use anything else than == in tested-with (it doesn't seem to be documented anywhere). Makes sense if you indeed can.

And yeah, as you may have noticed from the GitHub messages about referenced commits/PRs, I have implemented exactly the check you suggest: liskin/xmonad-maintenance@50b9290

Seemed like a bit of a hack but good to know it's not 🙂

@phadej
Copy link
Collaborator Author

phadej commented May 6, 2024

haskell-ci is not meant nor designed to be run in non-supervised environments.

@liskin
Copy link

liskin commented May 6, 2024

It creates a pull request, that's supervised enough for us 😏
Still, we want to automate as much as possible. Relying on humans tends to disappoint. Hence the safety check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What to do with older GHCs.
2 participants