change type of Hash.hash to MEDIUMTEXT instead of TEXT to allow longer hashes #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyronix
requested changes
Mar 20, 2023
| @@ -10,4 +12,9 @@ | |||
| require_once(dirname(__FILE__) . "/../../inc/defines/config.php"); | |||
| require_once(dirname(__FILE__) . "/../../inc/defines/log.php"); | |||
|
|
|||
| if (!isset($PRESENT["v0.13.x_hash_length"])) { | |||
| Factory::getAgentFactory()->getDB()->query("ALTER TABLE `Hash` MODIFY `hash` MEDIUMTEXT NOT NULL;"); | |||
There was a problem hiding this comment.
What if the database type is set to longtext? This change would modify that and thus cause issue when upgrading. Maybe add a check to this to check if the type is TEXT.
zyronix
approved these changes
Mar 20, 2023
|
@s3inlc I have fixed my own suggestion to double check that the column type is TEXT or smaller. I know that some people ahve already increased the size to LONGTEXT. This should prevent that from erroring or reverting back to MEDIUMTEXT. Could you verify my changes? |
|
Thanks, looks good. You're right, we should only increase if it's smaller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #851
closes issue #841