-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supertask runtime estimation #696
Conversation
Show estimated total runtime of a supertask, allowing the user to interactively size a supertask by adding or removing subtasks * Allow adding and removing subtasks to supertask * Parse hashcat command to compute runtime per subtask. Gratefully uses the code submitted by shivanraptor in hashtopolis#672 * Save line count of dictionary files and rule files in database * Compute runtime per subtask of supertask, depending on benchmark values entered by the user * Works for -a0 and -a3 hashcat attacks. Adds 'Unknown' to runtime estimate when not every subtask runtime could be estimated * Feature includes custom charsets for masks in -a3 attacks
Thanks a lot for the PR. I have some minor things which we hopefully can resolve before merging. It gives some nice insights for users for given tasks, additionally the line count is useful even outside of the estimation calculation.
I hope it is understandable what I mean, it would be great if you could adjust these small things and then I will gladly merge the PR. Thanks :) |
change todo comments ensure generic cracker attacks result in an unknown runtime estimate add lineCount to initial sql file update changelog
Good points! Thank you for the review. I'll comment on the bullet points one by one.
Thanks again! |
Talked with @s3inlc and this still is a very usefull pull request. The following should be implemented: One of the tables contained a vertical scroll bar, remove that
|
Continued work in #750 |
Show estimated total runtime of a supertask, allowing the user to interactively come to the desired size of a supertask by adding or removing subtasks on the supertask detail page
Features:
Thank you, shivanraptor, for sharing your code with the community!
Future work and additional remarks: