Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User register mail contains two To: header fields #751

Closed
christianschneider89 opened this issue Apr 8, 2022 · 2 comments · Fixed by #770
Closed

User register mail contains two To: header fields #751

christianschneider89 opened this issue Apr 8, 2022 · 2 comments · Fixed by #770
Assignees
Labels
bug Something isn't working

Comments

@christianschneider89
Copy link

christianschneider89 commented Apr 8, 2022

server version from commit a907491

When I create a new user, the mail which is sent to the mail server contains two "To:" header fields:

From www-data@redacted  Fri Apr  8 11:32:05 2022
Return-Path: <www-data@redacted>
Received: from redacted (localhost [127.0.0.1])
        by redacted (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 2389W5nG016185
        for <redacted@redacted>; Fri, 8 Apr 2022 11:32:05 +0200
Received: (from www-data@localhost)
        by redacted (8.15.2/8.15.2/Submit) id 2389W5pQ016184;
        Fri, 8 Apr 2022 11:32:05 +0200
Date: Fri, 8 Apr 2022 11:32:05 +0200
Message-Id: <202204080932.2389W5pQ016184@redacted>
To: redacted@redacted
Subject: Account at Hashtopolis
MIME-Version: 1.0
From: Hashtopolis <hashtopolis@redacted>
To: redacted@redacted
Content-Type: multipart/alternative;boundary=np625001155b4d5



--np625001155b4d5
Content-type: text/plain;charset=utf-8

Hi redacted,

Your account on Hashtopolis was created. You can now log in with the following credentials:
Username: redacted
Password: redacted
Go to Hashtopolis: http://redacted/hashtopolis

--np625001155b4d5
Content-type: text/html;charset=utf-8

Hi redacted,<br><br>
<p>
        Your account on Hashtopolis was created. You can now log in with the following credentials:<br>
        Username: <code>redacted</code><br>
        Password: <code>redacted</code><br><br>
        Go to Hashtopolis: <a href='http://redacted/hashtopolis'>http://redacted/hashtopolis</a>
</p>

--np625001155b4d5--
@s3inlc s3inlc added the bug Something isn't working label Apr 9, 2022
@s3inlc
Copy link
Member

s3inlc commented Apr 9, 2022

Thanks for the report. Indeed, the To: value is included twice because it is provided also in the additional headers passed to the mail() function here: https://github.com/hashtopolis/server/blob/master/src/inc/Util.class.php#L1259

We will fix this.

@zyronix
Copy link
Member

zyronix commented May 20, 2022

Should be fixed with #770

Repository owner moved this from Review to Done in Release 0.13.0 Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants