Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-4026: Enable showing the modal to update dependent entity types #6426

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

CiaranMn
Copy link
Member

@CiaranMn CiaranMn commented Feb 12, 2025

🌟 What is the purpose of this PR?

This PR un-hides the modal introduced in #6366 which allows users to update types which are dependent on the type being updated.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

  • Currently not all dependent types will be correctly found. This is because of an issue with any filters in the Graph API whereby if you use a query path which depends on a table join (e.g. inheritsFrom), only those types which have some value for that path will be possible returns, even if types which don't have anything they e.g. inherit from match another of the any filter. In this context, this means that it will only find dependents which have something they inherit from, and some link. Types without either a parent or any links will not be found. Tracked in H-4015.

🐾 Next steps

  • The same 'offer to update type dependents' work needs to be done when updating a property type (H-4027) and data type (H-4061).

🛡 What tests cover this?

  • None yet.

❓ How to test this?

  1. Not possible locally as depends on Node API changes

@CiaranMn CiaranMn self-assigned this Feb 12, 2025
@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/apps labels Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 20.99%. Comparing base (035b26c) to head (a654b9b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...sh-api/src/graph/ontology/primitive/entity-type.ts 0.00% 10 Missing ⚠️
...-api/src/graphql/resolvers/ontology/entity-type.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6426      +/-   ##
==========================================
- Coverage   21.00%   20.99%   -0.02%     
==========================================
  Files         583      583              
  Lines       20048    20058      +10     
  Branches     2992     2993       +1     
==========================================
  Hits         4212     4212              
- Misses      15779    15789      +10     
  Partials       57       57              
Flag Coverage Δ
apps.hash-api 1.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from t/h-4023-allow-updating-multiple-entity-types-at-once to main February 12, 2025 13:31
@CiaranMn CiaranMn force-pushed the cm/enable-showing-update-dependent-type-modal branch from debe7f7 to a654b9b Compare February 12, 2025 15:03
@CiaranMn CiaranMn requested a review from vilkinsons February 12, 2025 15:03
@CiaranMn CiaranMn marked this pull request as ready for review February 12, 2025 15:03
@CiaranMn CiaranMn added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit f5c8eb1 Feb 12, 2025
40 checks passed
@CiaranMn CiaranMn deleted the cm/enable-showing-update-dependent-type-modal branch February 12, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team
Development

Successfully merging this pull request may close these issues.

2 participants