Upgrades to integrations-hcl to support multiple strategies (Nomad Pack) #216
Conversation
🦋 Changeset detectedLatest commit: 0045982 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Canary Packages PublishedLatest commit: 0045982 |
| app: app.array().length(1), | ||
| pack: pack.array().length(1), | ||
| integration: integration.array().length(1), | ||
| }) |
There was a problem hiding this comment.
Are app and pack Nomad-owned stanzas? and integration Digital-owned? It might be useful to note that here.
Also, we might want to add the missing app and pack fields here, even though we may not necessarily need them.
There was a problem hiding this comment.
Are app and pack Nomad-owned stanzas? and integration Digital-owned? It might be useful to note that here.
Yes this is the right understanding. I will note this!
Also, we might want to add the missing app and pack fields here, even though we may not necessarily need them.
I would be concerned that we would be over-validating. For example, if they have a field xyz which is currently required, I wouldn't want to specify it as such in our configuration if we don't need to use it. In the event that the Nomad team wants to change their specification, I wouldn't want to have to change anything on our end (unless it was fields that we were touching).
BrandonRomano
changed the title
🎟️ Asana Task
Description
Upgrades the
integrations-hclcodebase to support an inputstrategyparameter which influences the strategy of consumption.This allows for differing consumption interfaces, which is required given our nomad-pack-community-registry has a different configuration interface.
PR Checklist 🚀