DBPW - Add test helpers for DB v5 interface #9948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Sep 14, 2020
| func AssertInitialize(t *testing.T, db newdbplugin.Database, req newdbplugin.InitializeRequest) newdbplugin.InitializeResponse { | ||
| t.Helper() | ||
|
|
||
| ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second) |
There was a problem hiding this comment.
Can we make this a tunable value? It may be sufficient for certain cases such as mocked databases, but 2 seconds might not be enough if operations end up taking longer than this duration for certain databases which can happen on CI (depending on load, machine type/size, etc.) and result in flaky tests.
There was a problem hiding this comment.
I'm hesitant to add too much configurability to these as these are meant for the common use case. If they don't work for a specific database, those tests can fall back to calling the database functions directly.
There was a problem hiding this comment.
I added the ability to change the timeouts via env variable with a default of 2s.
calvn
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is part of a larger feature adding support for password policies into the combined database engine. This feature is being split into multiple PRs to make for smaller reviews & earlier feedback.
Adds some test helper functions to call the various functions on the v5
Databaseinterface with common assertions (no error,NewUsergives a non-empty username). These do not preclude calling the functions directly in a test if needed. These are made available for the common testing use cases.Related PRs
Original password policies PR
1/X - Database interface & gRPC
2/X - Middleware
3/X - Plugin management
4/X - Database engine