Require TLS or plaintext flagging in MySQL configuration #9012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalafut
reviewed
May 15, 2020
added 3 commits
May 18, 2020 13:42
This requires a user to either use TLS, or acknowledge that they are sending credentials over plaintext.
Valarissa
force-pushed
the
VLTE-346-prevent_accidental_plaintext_creds
branch
from
8b85f23 to
8812ed2
Compare
|
@tyrannosaurus-becks I've updated this PR with the requested changes. |
tyrannosaurus-becks
previously approved these changes
May 20, 2020
briankassouf
previously approved these changes
May 20, 2020
Valarissa
dismissed stale reviews from briankassouf and tyrannosaurus-becks
via
bb855a5
briankassouf
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user is using a MySQL backend, this change requires a user to either use TLS, or acknowledge that they are sending credentials over plaintext.
This may break some developer workflows.