Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: service account key should use config ttl #8946

Merged
merged 1 commit into from
May 15, 2020

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented May 7, 2020

@kalafut kalafut added this to the 1.4.2 milestone May 7, 2020
Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you make sure to PR this into master as well?

@kalafut
Copy link
Contributor Author

kalafut commented May 15, 2020

Looks good, but can you make sure to PR this into master as well?

Updated in #9004

@kalafut kalafut merged commit ae6cc3d into release/1.4.x May 15, 2020
@kalafut kalafut deleted the backport-gcp-secrets branch May 15, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants