Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role_id as an alias name source for AWS and change the defaults #6133

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

jefferai
Copy link
Member

No description provided.

@jefferai jefferai added this to the 1.0.3 milestone Jan 30, 2019
@jefferai jefferai requested a review from vishalnayak January 30, 2019 20:52
@jefferai jefferai merged commit b6f40b5 into master Jan 30, 2019
@jefferai
Copy link
Member Author

@vishalnayak I .... did not mean to merge this. Rather than force-push back, can you just review after-the-fact?

@jefferai jefferai deleted the aws-alias-roleid branch January 30, 2019 21:21
Copy link
Contributor

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

joelthompson added a commit to joelthompson/vault that referenced this pull request Jan 31, 2019
Small typo introduced in hashicorp#6133
@joelthompson
Copy link
Contributor

@jefferai -- I'm not entirely certain that this will do as the entry in the changelog says. In particular, the changelog entry states, "Existing mounts will not be affected." However, I believe this can affect existing mount points. identityConfigEntry in path_config_identity.go is where the default values are added; however, an updated config entry with the default values is never written back to storage. So, if a user has never set the identity config of a mount, then before upgrading, logins would get identity aliases corresponding to identityAliasIAMUniqueID and identityAliasEC2InstanceID, while after upgrading, logins would get identity aliases of the role ID. Right? This might be fine as a breaking change, fixing it would probably require versioning the identityConfig struct along with an upgrade path, and I'm not sure it's worth the added complexity versus just calling something out in the changelog with instructions on how to opt back in to the old behavior if people cared.

kalafut pushed a commit that referenced this pull request Jan 31, 2019
Small typo introduced in #6133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants