Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add entity lookup to the default policy #6105

Merged
merged 5 commits into from
Jan 29, 2019
Merged

add entity lookup to the default policy #6105

merged 5 commits into from
Jan 29, 2019

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Jan 25, 2019

No description provided.

jefferai
jefferai previously approved these changes Jan 25, 2019
View reviewed changes
@jefferai jefferai added this to the 1.0.3 milestone Jan 25, 2019
briankassouf
briankassouf previously approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@briankassouf
Copy link
Contributor

@meirish Could you also add this to the CHANGES section of the changelog?

@meirish
Copy link
Contributor Author

meirish commented Jan 25, 2019

@briankassouf Yep, will do - I just added lookup by name back as well.

@meirish meirish merged commit e48d759 into master Jan 29, 2019
@meirish meirish deleted the identity-defaults branch January 29, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

@jefferai jefferai jefferai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@meirish @briankassouf @jefferai